wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/14398 )
Change subject: IMPALA-8974: Fixed a bug when create kudu managed table without HMS config ...................................................................... Patch Set 8: (4 comments) > (5 comments) > > Thank you for adding the test. I have some concerns about how it > changes config files around, so I proposed an alternative solution. Thanks for your review, Tim. I've already solved the problems you mentioned above. If there is a chance, I will try to write custom cluster test in Python instead of Java. http://gerrit.cloudera.org:8080/#/c/14398/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14398/5//COMMIT_MSG@7 PS5, Line 7: managed > spelling: managed (also a few cases below). Done http://gerrit.cloudera.org:8080/#/c/14398/5/fe/src/test/java/org/apache/impala/customcluster/CreateKuduTableWithoutHMSTest.java File fe/src/test/java/org/apache/impala/customcluster/CreateKuduTableWithoutHMSTest.java: http://gerrit.cloudera.org:8080/#/c/14398/5/fe/src/test/java/org/apache/impala/customcluster/CreateKuduTableWithoutHMSTest.java@35 PS5, Line 35: managed > spelling: managed Done http://gerrit.cloudera.org:8080/#/c/14398/5/fe/src/test/java/org/apache/impala/customcluster/CreateKuduTableWithoutHMSTest.java@66 PS5, Line 66: sultSet > spelling: managed Done http://gerrit.cloudera.org:8080/#/c/14398/5/fe/src/test/java/org/apache/impala/customcluster/CreateKuduTableWithoutHMSTest.java@84 PS5, Line 84: } > I don't really like this test modifying global test configs, it really risk Done -- To view, visit http://gerrit.cloudera.org:8080/14398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iacc53801a660c033869cb4747910c98a80e08297 Gerrit-Change-Number: 14398 Gerrit-PatchSet: 8 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2019 12:21:04 +0000 Gerrit-HasComments: Yes
