Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14538 )
Change subject: IMPALA-4400: aggregate runtime filters locally ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/14538/9/be/src/runtime/runtime-filter-bank.h File be/src/runtime/runtime-filter-bank.h: http://gerrit.cloudera.org:8080/#/c/14538/9/be/src/runtime/runtime-filter-bank.h@193 PS9, Line 193: /// Contains references to all the min-max filters generated. Used in Close() to safely > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/14538/9/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/14538/9/fe/src/main/java/org/apache/impala/planner/Planner.java@444 PS9, Line 444: totalRuntimeFilterMemBytes += fragment.getProducedRuntimeFiltersMemReservationBytes(); > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/14538/9/tests/custom_cluster/test_mt_dop.py File tests/custom_cluster/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/14538/9/tests/custom_cluster/test_mt_dop.py@90 PS9, Line 90: > flake8: W391 blank line at end of file Done -- To view, visit http://gerrit.cloudera.org:8080/14538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iabeeab5eec869ff2197250ad41c1eb5551704acc Gerrit-Change-Number: 14538 Gerrit-PatchSet: 9 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2019 18:24:01 +0000 Gerrit-HasComments: Yes
