Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14592 )
Change subject: IMPALA-2112: Support primary key/foreign key constraints as part of create table in Impala. ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/14592/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/14592/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@959 PS1, Line 959: primaryKeys_.addAll(client.getPrimaryKeys(new PrimaryKeysRequest(msTbl.getDbName(), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14592/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14592/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@2391 PS1, Line 2391: AnalysisError("create table fk(id int, foreign key(id) references non_pk_table(id))", ctx, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14592/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java File fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java: http://gerrit.cloudera.org:8080/#/c/14592/1/fe/src/test/java/org/apache/impala/analysis/ToSqlTest.java@384 PS1, Line 384: + "(year))", "CREATE TABLE test_pk_fk.fk ( id INT, year STRING, FOREIGN KEY(id) " line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id03d8d4d41a2ac1b15e7060e2a013e334d044ee7 Gerrit-Change-Number: 14592 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2019 22:52:56 +0000 Gerrit-HasComments: Yes
