Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14575 )
Change subject: IMPALA-8768: [DOCS] Added conditions for queries recorded in audit log ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14575/1/docs/topics/impala_auditing.xml File docs/topics/impala_auditing.xml: http://gerrit.cloudera.org:8080/#/c/14575/1/docs/topics/impala_auditing.xml@269 PS1, Line 269: <li>Queries with at least one fetch issued by the client.</li> IMPALA-8572 (coming in 3.4) actually changed this slightly, so that queries are logged as soon as results are available to be fetched by clients, so before the first fetch occurs. Bharath said in the commit message: The conditions under which the events are logged are slightly modified by this patch. Without the patch, events are logged for unsuccessful queries if atleast a single fetch is perfomed. This patch relaxes this guarantee to log events for any query that reaches the FINISHED state (rows are available to fetch by the client) and does not wait for a fetch to be performed. This simplifies the coordinator state machine by avoiding unnecessary synchronization. -- To view, visit http://gerrit.cloudera.org:8080/14575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I809e716e66558db02e6401bd218b3dd2de49864c Gerrit-Change-Number: 14575 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2019 23:07:37 +0000 Gerrit-HasComments: Yes
