Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 )
Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14600/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14600/2//COMMIT_MSG@14 PS2, Line 14: Testing: We usually add end to end test for it. http://gerrit.cloudera.org:8080/#/c/14600/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/14600/2/fe/src/main/java/org/apache/impala/catalog/Table.java@102 PS2, Line 102: // Time spend on table metadata loading. (ns) For the value is median loading time, you may need to add comments to state that. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 2 Gerrit-Owner: Jiawei Wang <jiawei.w...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Oct 2019 13:30:52 +0000 Gerrit-HasComments: Yes