Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14610 )
Change subject: IMPALA-9116: Work around SASL bug when FQDN is >=64 characters in Kudu RPC. ...................................................................... Patch Set 1: (1 comment) LGTM. Is the plan to do it on Impala side first and then backport it to Kudu ? We usually do changes the other way (i.e. from Kudu side first and then cherry-picked to Impala side). http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc File be/src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/14610/1/be/src/kudu/rpc/server_negotiation.cc@391 PS1, Line 391: (!server_fqdn nit: server_fqdn == nullptr -- To view, visit http://gerrit.cloudera.org:8080/14610 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f05f70915ed20c97efd0ae7295b181a010cf0f6 Gerrit-Change-Number: 14610 Gerrit-PatchSet: 1 Gerrit-Owner: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 01 Nov 2019 06:07:08 +0000 Gerrit-HasComments: Yes
