Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14621 )
Change subject: IMPALA-8557: Add '.txt' to text files, remove '.' at end of filenames ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14621/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14621/3//COMMIT_MSG@21 PS3, Line 21: Impala writes all text files with a trailing dot due to some odd : behavior in hdfs-table-sink.cc Can you mention that text tables created during dataload already used .txt extension? I was surprised at first that no existing test had to be changed (e.g. ones that use SHOW FILES), but then I realized that functional.alltypes and friends already used .txt extension as they are copied instead of created by INSERT. -- To view, visit http://gerrit.cloudera.org:8080/14621 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a9adacd45855cde86724e10f8a131e17ebf46f8 Gerrit-Change-Number: 14621 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2019 15:26:43 +0000 Gerrit-HasComments: Yes
