Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14600 )
Change subject: IMPALA-9109: Add top-k metadata loading ranking on catalogd UI ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/14600/6/be/src/catalog/catalog-server.h File be/src/catalog/catalog-server.h: http://gerrit.cloudera.org:8080/#/c/14600/6/be/src/catalog/catalog-server.h@215 PS6, Line 215: long_75_loading_time I think names like "p75_loading_time_ns", "p95_loading_time_ns" are better. http://gerrit.cloudera.org:8080/#/c/14600/6/www/scripts/util.js File www/scripts/util.js: http://gerrit.cloudera.org:8080/#/c/14600/6/www/scripts/util.js@36 PS6, Line 36: nanoseconds % 1000 Should be "nanoseconds / 1000 % 1000" and should deal with adding leading 0s, otherwise getReadableTime(1) will result in "0.1ms" There's an example in backend: https://github.com/apache/impala/blob/288abf10f6142ae6cb02329604805a9a1dcc804f/be/src/util/pretty-printer.h#L249 Maybe we can do the same in JS. -- To view, visit http://gerrit.cloudera.org:8080/14600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9305a867d7053cde9acc42dae6e47ee440f1a8bf Gerrit-Change-Number: 14600 Gerrit-PatchSet: 6 Gerrit-Owner: Jiawei Wang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Xiaomeng Zhang <[email protected]> Gerrit-Reviewer: Yongzhi Chen <[email protected]> Gerrit-Comment-Date: Tue, 05 Nov 2019 02:38:50 +0000 Gerrit-HasComments: Yes
