Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14444 )

Change subject: IMPALA-8648: Add stress tests for ACID INSERTs/SELECTs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14444/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/14444/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@753
PS4, Line 753:       if(catalog_.getLock().isWriteLockedByCurrentThread()) {
             :         LOG.error("Write lock should have been released.");
             :         catalog_.getLock().writeLock().unlock();
             :       }
> It would be nice to create a function for this, I just can't find a good na
I couldn't come up with a better name either.



--
To view, visit http://gerrit.cloudera.org:8080/14444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I066652bfa7d924742af01aef8df4512e00620c7d
Gerrit-Change-Number: 14444
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Norbert Luksa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 06 Nov 2019 15:31:12 +0000
Gerrit-HasComments: Yes

Reply via email to