Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13882 )
Change subject: IMPALA-7984: Port runtime filter from Thrift RPC to KRPC ...................................................................... Patch Set 29: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13882/29/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: http://gerrit.cloudera.org:8080/#/c/13882/29/be/src/util/bloom-filter.h@162 PS29, Line 162: static void AddDirectorySidecar(BloomFilterPB* rpc_params, : kudu::rpc::RpcController* controller, const char* directory, : unsigned long directory_size); : static void AddDirectorySidecar(BloomFilterPB* rpc_params, : kudu::rpc::RpcController* controller, const string& directory); > I don't think its necessary to have two versions of this function. You shou We talked offline and I was wrong -- To view, visit http://gerrit.cloudera.org:8080/13882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b394796d250286510e157ae326882bfc01d387a Gerrit-Change-Number: 13882 Gerrit-PatchSet: 29 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Fri, 08 Nov 2019 00:11:50 +0000 Gerrit-HasComments: Yes
