Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14640 )
Change subject: IMPALA-9129: Add a test fixture that cleans up intentional core dumps ...................................................................... IMPALA-9129: Add a test fixture that cleans up intentional core dumps Some negative tests produce core dumps intentionally. We should have a way of removing these as part of test cleanup. For custom cluster tests, it's likely the cores may actually be generated during the base class setup phase, which means it's too early for the test fixture to really be useful. Such was the case with the test case TestAuthorizationProvider::test_invalid_provider_flag. In this instance, we had to add the same steps directly to the tests. Testing done: For test_invalid_provider_flag, I made sure I had pre-existing core files in the IMPALA_HOME directory, then ran the test to confirm new cores were removed. -- 2019-11-06 19:53:27,303 INFO MainThread: Removing core.impalad.61852 created by test_invalid_provider_flag -- 2019-11-06 19:53:27,375 INFO MainThread: Removing core.impalad.61856 created by test_invalid_provider_flag -- 2019-11-06 19:53:27,450 INFO MainThread: Removing core.impalad.61849 created by test_invalid_provider_flag ...and then made sure the pre-existing cores were still present. Change-Id: I778f27e820a6983894c1294d35627ddb04f5a51a Reviewed-on: http://gerrit.cloudera.org:8080/14640 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- A lib/python/impala_py_lib/helpers.py M tests/authorization/test_provider.py M tests/conftest.py 3 files changed, 108 insertions(+), 3 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I778f27e820a6983894c1294d35627ddb04f5a51a Gerrit-Change-Number: 14640 Gerrit-PatchSet: 8 Gerrit-Owner: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
