wangsheng has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14398 )

Change subject: IMPALA-8974: Fixed a bug when create kudu managed table without 
HMS config
......................................................................


Patch Set 12:

> (7 comments)
 >
 > Sorry for my late reply. I've also added some logics for using
 > customized hive-site.xml in https://gerrit.cloudera.org/c/14527
 > (you may need a rebase to see the latest changes), which can
 > simplify some works here, e.g. don't need TEST_PREPEND_CLASSPATH.
 >
 > The changes are small but it's a big topic that configuring
 > catalogd without HMS (not sure if I understand correctly). Does it
 > work as expected after this patch, or there're other relative
 > broken preconditions also need to fix? I'm quite curious about this
 > scenario and would be appreciated if you could share more!

Thanks for your review, Quanlong. I've already modify the patch according to 
your advice.


--
To view, visit http://gerrit.cloudera.org:8080/14398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacc53801a660c033869cb4747910c98a80e08297
Gerrit-Change-Number: 14398
Gerrit-PatchSet: 12
Gerrit-Owner: wangsheng <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
Gerrit-Comment-Date: Mon, 11 Nov 2019 12:57:47 +0000
Gerrit-HasComments: No

Reply via email to