Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14661 )

Change subject: IMPALA-8855: [DOCS] Document the generic VALUES clause
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14661/2/docs/topics/impala_values.xml
File docs/topics/impala_values.xml:

http://gerrit.cloudera.org:8080/#/c/14661/2/docs/topics/impala_values.xml@58
PS2, Line 58:       <li>The corresponding <varname>column</varname>s must have 
the same data
They can be different as long as they can be cast between each other. E.g. 
here's a query with mixed string and timestamp.

  [localhost:21000] default> values (cast('2019-01-01' as timestamp)), 
('2019-02-02');
  Query: values (cast('2019-01-01' as timestamp)), ('2019-02-02')
  +---------------------------------+
  | cast('2019-01-01' as timestamp) |
  +---------------------------------+
  | 2019-01-01 00:00:00             |
  | 2019-02-02 00:00:00             |
  +---------------------------------+
  Fetched 2 row(s) in 0.11s


Maybe reword to "must have compatible data types in all rows", or similar. I 
didn't see anywhere in the docs where we actually discuss what types can be 
implicitly cast to other types, but maybe I missed it.



--
To view, visit http://gerrit.cloudera.org:8080/14661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2568450993323236535a8f1d022dee7d09ecf62b
Gerrit-Change-Number: 14661
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 12 Nov 2019 17:22:17 +0000
Gerrit-HasComments: Yes

Reply via email to