Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14672 )
Change subject: IMPALA-9082: make WebserverTest error checking stricter ...................................................................... IMPALA-9082: make WebserverTest error checking stricter WebserverTest::TestWithSpnego has been flaky lately, but I have been unable to repro it. This patch is an attempt to make it easier to debug the issue the next time it shows up in automated builds. The test performs a GET that is expected to fail and then checks that the metrics show the failed GET. The flaky failures occur when the metrics do not show a failed attempt. It appears that what's happening is the GET is failing before actually reaching the webserver. However, because the GET is expected to fail and because we only verify that it did fail by checking that HttpGet() returned some error status, whatever unexpected error is occuring is getting lost. This patch instead checks the actual text of the error that is returned by HttpGet() to make sure it is correct and logs the error if it isn't. Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc Reviewed-on: http://gerrit.cloudera.org:8080/14672 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M be/src/testutil/gtest-util.h M be/src/util/webserver-test.cc 2 files changed, 13 insertions(+), 2 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14672 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I820336271cf25130538ceae2eed10a72a73d2adc Gerrit-Change-Number: 14672 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
