Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14668 )
Change subject: IMPALA-9128: part 2: dump traces for slow RPCs ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/14668/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14668/5//COMMIT_MSG@38 PS5, Line 38: * basic perf testing > Is tracing on by default? I assume the perf impact is negligible? I think so in practice, but wanted to do a sanity test. It does always log the trace to a buffer, which requires allocating memory from an arena and substituting the message text. Should be negligible in the context of other overhead from the RPC, but wanted to be sure, since I did add several additional traces per RPC. -- To view, visit http://gerrit.cloudera.org:8080/14668 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7af4b45c43ec731d742d3696112c5f800849947 Gerrit-Change-Number: 14668 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2019 01:55:05 +0000 Gerrit-HasComments: Yes
