Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14714 )
Change subject: IMPALA-8705: ISO:SQL:2016 datetime patterns - Milestone 3 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14714/1/be/src/runtime/datetime-parser-common.cc File be/src/runtime/datetime-parser-common.cc: http://gerrit.cloudera.org:8080/#/c/14714/1/be/src/runtime/datetime-parser-common.cc@197 PS1, Line 197: const auto* search_map = &MONTH_NAME_TO_INDEX; : if (type == MONTH_NAME_SHORT) search_map = &SHORT_MONTH_NAME_TO_INDEX; > nit: Using the ternary operator and a constant reference instead of a point Ok, I messed this up :) const auto& search_map = (type == MONTH_NAME) ? MONTH_NAME_TO_INDEX : SHORT_MONTH_NAME_TO_INDEX; -- To view, visit http://gerrit.cloudera.org:8080/14714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic797f19a1311b54e5d00d01d0a7afe1f0f21fb8f Gerrit-Change-Number: 14714 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 15 Nov 2019 14:55:57 +0000 Gerrit-HasComments: Yes
