Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14562 )
Change subject: IMPALA-9107 (part 1): Add scripts to produce an m2 archive ...................................................................... Patch Set 9: (2 comments) Thanks for the review! I'm making a minor change that uses a trap to cleanup the temporary directories. After that, I'll go ahead with this. http://gerrit.cloudera.org:8080/#/c/14562/9/bin/jenkins/archive_m2_directory.sh File bin/jenkins/archive_m2_directory.sh: http://gerrit.cloudera.org:8080/#/c/14562/9/bin/jenkins/archive_m2_directory.sh@39 PS9, Line 39: # characters to format things on the console (e.g. carriage return ^M). > Add set -euo pipefail? Done http://gerrit.cloudera.org:8080/#/c/14562/9/bin/jenkins/get_maven_statistics.sh File bin/jenkins/get_maven_statistics.sh: http://gerrit.cloudera.org:8080/#/c/14562/9/bin/jenkins/get_maven_statistics.sh@28 PS9, Line 28: # characters to format things on the console (e.g. carriage return ^M). > set -euo pipefail here too? Done -- To view, visit http://gerrit.cloudera.org:8080/14562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I043912f5fbc7cf24ee80b2855354656aa587ca9f Gerrit-Change-Number: 14562 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Sat, 16 Nov 2019 01:25:30 +0000 Gerrit-HasComments: Yes
