Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14059 )
Change subject: IMPALA-8863: Add support to run tests over HTTP/HS2 ...................................................................... Patch Set 26: (1 comment) http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/14059/26/tests/hs2/test_hs2.py@54 PS26, Line 54: HS2TestSuite.check_response(hs2_client.CloseSession(close_session_req)) > This code already throws anything that comes out of check_response, i.e. As My comment was confusingly worded - I was wondering if we should suppress it, but then thought that it's probably better not to. -- To view, visit http://gerrit.cloudera.org:8080/14059 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7156558071781378fcb9c8941c0f4dd82eb0d018 Gerrit-Change-Number: 14059 Gerrit-PatchSet: 26 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2019 01:13:48 +0000 Gerrit-HasComments: Yes
