Sahil Takiar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14741 )

Change subject: IMPALA-9165: Add timeout for create-load-data.sh
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh
File bin/script-timeout-check.sh:

http://gerrit.cloudera.org:8080/#/c/14741/1/bin/script-timeout-check.sh@74
PS1, Line 74: --step "test_run"
does this parameter, or the --phase parameter need to be changed depending on 
if this is calling during test execution vs. data load?


http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh
File testdata/bin/create-load-data.sh:

http://gerrit.cloudera.org:8080/#/c/14741/1/testdata/bin/create-load-data.sh@106
PS1, Line 106: minute
nit: minutes



--
To view, visit http://gerrit.cloudera.org:8080/14741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19d76bd8850c7d4b5affff4d21f32d8715a382c6
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Sahil Takiar <[email protected]>
Gerrit-Comment-Date: Tue, 19 Nov 2019 16:24:21 +0000
Gerrit-HasComments: Yes

Reply via email to