Hello Thomas Tauber-Marshall, Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14632
to look at the new patch set (#6).
Change subject: IMPALA-9126: part 1: hash join build partition cleanup
......................................................................
IMPALA-9126: part 1: hash join build partition cleanup
Clarify some invariants (e.g. which join modes actually
require build partition data to be attached to row batches).
Move some logic for maintenance of the hash partitions to
the builder.
Testing:
Ran exhaustive tests. We should already have adequate coverage for
spilling and non-spilling hash joins.
Change-Id: Ife8d0fa5dd14c7d3f3d726dd38c07d8cbceabadb
---
M be/src/exec/blocking-join-node.cc
M be/src/exec/blocking-join-node.h
A be/src/exec/join-op.h
M be/src/exec/nested-loop-join-node.cc
M be/src/exec/partitioned-hash-join-builder.cc
M be/src/exec/partitioned-hash-join-builder.h
M be/src/exec/partitioned-hash-join-node.cc
M be/src/exec/partitioned-hash-join-node.h
8 files changed, 166 insertions(+), 106 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/32/14632/6
--
To view, visit http://gerrit.cloudera.org:8080/14632
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife8d0fa5dd14c7d3f3d726dd38c07d8cbceabadb
Gerrit-Change-Number: 14632
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Bikramjeet Vig <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
