Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14750 )
Change subject: IMPALA-9092: Add support for creating external Kudu table ...................................................................... Patch Set 1: (43 comments) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@397 PS1, Line 397: private void analyzeSynchronizedKuduTableParams(Analyzer analyzer) throws AnalysisException { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@441 PS1, Line 441: private void analyzeSynchronizedKuduTableName(Analyzer analyzer) throws AnalysisException { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2239 PS1, Line 2239: !KuduTable.isSynchronizedTable(newTable) || !isKuduHmsIntegrationEnabled(newTable); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@44 PS1, Line 44: return super.AnalyzesOk(appendSynchronizedTblProps(stmt, isSynchronizedTbl), errorStr); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@65 PS1, Line 65: super.AnalysisError(appendSynchronizedTblProps(stmt, isSynchronizedTbl), expectedError); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@97 PS1, Line 97: "partition value = (cast (30 as int), factorial(5))) stored as kudu", isSynchronizedTable); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@171 PS1, Line 171: "partitioning columns: (2 vs 1). Range partition: 'PARTITION VALUE = (1, 2)'", isSynchronizedTable); line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@196 PS1, Line 196: "(partition value = false, partition value = true) stored as kudu", isSynchronizedTable); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@212 PS1, Line 212: "(PARTITION VALUE = 'abc')' is not a key column. Only key columns can be used " + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@238 PS1, Line 238: "Unpartitioned Kudu tables are inefficient for large data sizes.", isSynchronizedTable); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@242 PS1, Line 242: "Table property 'kudu.num_tablet_replicas' must be an integer.", isSynchronizedTable); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@252 PS1, Line 252: "Unpartitioned Kudu tables are inefficient for large data sizes.", isSynchronizedTable); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@265 PS1, Line 265: "partition by range(a, b) (partition (0, 0) < values <= (1, 1)) stored as kudu", isSynchronizedTable); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@273 PS1, Line 273: "partitioning columns: (1 vs 2). Range partition: 'PARTITION 0 < VALUES <= 1'", isSynchronizedTable); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@315 PS1, Line 315: AnalysisError(createTblStr, "Primary key columns cannot be nullable", isSynchronizedTable); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@355 PS1, Line 355: "algorithms are: " + Joiner.on(", ").join(CompressionAlgorithm.values()), isSynchronizedTable); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@369 PS1, Line 369: "isnull(null, null)) partition by hash (i) partitions 3 stored as kudu", isSynchronizedTable); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@373 PS1, Line 373: "'string_val' (type: STRING) is not compatible with column 'i' (type: INT).", isSynchronizedTable); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@380 PS1, Line 380: "128 (type: SMALLINT) is not compatible with column 'i' (type: TINYINT).", isSynchronizedTable); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@391 PS1, Line 391: "for BLOCK_SIZE: 1.1. A positive INTEGER value is expected.", isSynchronizedTable); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@394 PS1, Line 394: "for BLOCK_SIZE: 'val'. A positive INTEGER value is expected.", isSynchronizedTable); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@434 PS1, Line 434: "compatible with partitioning column 'ts' (type: TIMESTAMP).", isSynchronizedTable); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@454 PS1, Line 454: "CAST('00:00:00' AS TIMESTAMP) cannot be cast to a TIMESTAMP literal.", isSynchronizedTable); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@458 PS1, Line 458: "String '2009-1 foo' cannot be cast to a TIMESTAMP literal.", isSynchronizedTable); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java File fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java: http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@272 PS1, Line 272: " id INT NOT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@273 PS1, Line 273: " bool_col BOOLEAN NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@274 PS1, Line 274: " tinyint_col TINYINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@275 PS1, Line 275: " smallint_col SMALLINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@276 PS1, Line 276: " int_col INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@277 PS1, Line 277: " bigint_col BIGINT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@278 PS1, Line 278: " float_col FLOAT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@279 PS1, Line 279: " double_col DOUBLE NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@280 PS1, Line 280: " date_string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@281 PS1, Line 281: " string_col STRING NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@282 PS1, Line 282: " timestamp_col TIMESTAMP NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@283 PS1, Line 283: " year INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java@284 PS1, Line 284: " month INT NULL ENCODING AUTO_ENCODING COMPRESSION DEFAULT_COMPRESSION,\n" + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py@842 PS1, Line 842: T flake8: E501 line too long (98 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py@1052 PS1, Line 1052: ' flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py@1071 PS1, Line 1071: ' flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py@1340 PS1, Line 1340: # flake8: E265 block comment should start with '# ' http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py@1364 PS1, Line 1364: ) flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/14750/1/tests/query_test/test_kudu.py@1369 PS1, Line 1369: flake8: W292 no newline at end of file -- To view, visit http://gerrit.cloudera.org:8080/14750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76f81d41db0cf2269ee1b365857164a43677e14d Gerrit-Change-Number: 14750 Gerrit-PatchSet: 1 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 20 Nov 2019 02:10:30 +0000 Gerrit-HasComments: Yes
