Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14716 )
Change subject: IMPALA-9126: part 2: no hj probe structures in build ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14716/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14716/8//COMMIT_MSG@7 PS8, Line 7: part 2: no hj probe structures in build nit: I would prefer to spell out hash join to make it clearer to people who are just browsing git log --oneline, e.g. "Remove probe structures from hash join builder". -- To view, visit http://gerrit.cloudera.org:8080/14716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0065f7f44f44f02b7616b1f694178ca42341c42d Gerrit-Change-Number: 14716 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 21 Nov 2019 20:39:00 +0000 Gerrit-HasComments: Yes
