Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14776 )

Change subject: IMPALA-7550: Add documentation to profile counters
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/14776/1/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

http://gerrit.cloudera.org:8080/#/c/14776/1/be/src/exec/hdfs-scan-node-base.cc@92
PS1, Line 92: 
PROFILE_DEFINE_SUMMARY_STATS_COUNTER(InitialRangeIdealReservation, DEBUG, LOW, 
TUnit::BYTES,
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/14776/1/be/src/util/runtime-profile-counters.h
File be/src/util/runtime-profile-counters.h:

http://gerrit.cloudera.org:8080/#/c/14776/1/be/src/util/runtime-profile-counters.h@171
PS1, Line 171:     // Medium level counters - somehow interesting counters to 
monitor. It will probably be
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/14776/1/be/src/util/runtime-profile-counters.h@296
PS1, Line 296:                                                     const 
std::string& parent_counter_name = "") {
line too long (98 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/14776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc03faddb27754001290bb6d899840e2cbe7ccb7
Gerrit-Change-Number: 14776
Gerrit-PatchSet: 1
Gerrit-Owner: Jiawei Wang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Thu, 21 Nov 2019 23:25:42 +0000
Gerrit-HasComments: Yes

Reply via email to