David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py File lib/python/impala_py_lib/helpers.py: http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py@43 PS1, Line 43: proc = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE) > Should we just use the second version always to reduce the amount of code. Makes sense. Afterwards, since bootstrap-toolchain.py is executed with impala-python, we could technically consolidate code a bit more by deleting that function and importing this function. Do you think I should that? -- To view, visit http://gerrit.cloudera.org:8080/14788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae Gerrit-Change-Number: 14788 Gerrit-PatchSet: 1 Gerrit-Owner: David Knupp <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 22 Nov 2019 20:57:05 +0000 Gerrit-HasComments: Yes
