Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14744 )
Change subject: IMPALA-6894: Use an internal representation of query states in ClientRequestState ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/14744/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/14744/3/be/src/service/client-request-state.cc@506 PS3, Line 506: UpdateNonErrorExecState(ExecState::PENDING); > This will actually mark the query pending even if the async-exec-thread cre Yeah, if the thread creation fails the state will be PENDING, and will eventually be set to ERROR by ClientRequestState::Cancel(status). So prior to this patch, if thread creation fails, the state would go from INITIALIZED to ERROR. After this patch, if thread creation fails, the state would go from INITIALIZED to PENDING to ERROR. Agree, don't think that change should be a problem. -- To view, visit http://gerrit.cloudera.org:8080/14744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce70bd2e964b309ebfc9d6ff6d900485db4d630 Gerrit-Change-Number: 14744 Gerrit-PatchSet: 3 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Sun, 24 Nov 2019 22:45:46 +0000 Gerrit-HasComments: Yes
