Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14804 )
Change subject: IMPALA-9174: Speedup allocations of ORC Scanner ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/14804/1/be/src/exec/hdfs-orc-scanner.cc File be/src/exec/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/14804/1/be/src/exec/hdfs-orc-scanner.cc@74 PS1, Line 74: return addr + sizeof(SizeType); This could cause problems if the caller is assuming that this is more than 8-byte aligned. I think malloc() gives 16 byte alignment by default. I think it's unlikely that ORC is assuming 16 byte alignment but might be worth confirming (maybe they're using int128_t for decimals or similar - we had seen issues with some SIMD instructions on 16-byte decimals faulting within Impala because they did aligned loads - we had to force unaligned loads with memcpy() in those cases). -- To view, visit http://gerrit.cloudera.org:8080/14804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09e746883176d6f955c1718267bf55e2abb239b Gerrit-Change-Number: 14804 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 27 Nov 2019 17:25:13 +0000 Gerrit-HasComments: Yes
