Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 )
Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file ...................................................................... Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/14811/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14811/3//COMMIT_MSG@19 PS3, Line 19: CREATE TABLE tablename LIKE ORC '/path/to/file' > CREATE TABLE LIKE without file format name always means Parquet? It would b CREATE TABLE LIKE 'path/to/file' is not a valid query and the file format has to be added explicitly, there is no default value. http://gerrit.cloudera.org:8080/#/c/14811/3/fe/src/main/java/org/apache/impala/analysis/ORCSchemeExtractor.java File fe/src/main/java/org/apache/impala/analysis/ORCSchemeExtractor.java: http://gerrit.cloudera.org:8080/#/c/14811/3/fe/src/main/java/org/apache/impala/analysis/ORCSchemeExtractor.java@80 PS3, Line 80: case BYTE: return Type.TINYINT; > I saw different type names in https://orc.apache.org/docs/types.html, e.g. In the documentation the ORC types are listed under the enum TypeDescription.Category, where these type names were present. It looks like that in the Java API the Java type equivalents were used. https://orc.apache.org/api/orc-core/org/apache/orc/TypeDescription.Category.html http://gerrit.cloudera.org:8080/#/c/14811/3/fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java File fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java: http://gerrit.cloudera.org:8080/#/c/14811/3/fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java@1 PS3, Line 1: package org.apache.impala.util; > Missing apache license (this also led to the build failure) Done http://gerrit.cloudera.org:8080/#/c/14811/3/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test: http://gerrit.cloudera.org:8080/#/c/14811/3/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test@58 PS3, Line 58: > nit: extra space Done http://gerrit.cloudera.org:8080/#/c/14811/3/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test@74 PS3, Line 74: ==== : ---- QUERY : drop table allcomplextypes_clone_orc : ---- RESULTS : 'Table has been dropped.' > Why is this needed? Other tables are not dropped + it is done automatically Done http://gerrit.cloudera.org:8080/#/c/14811/3/testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test File testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test: http://gerrit.cloudera.org:8080/#/c/14811/3/testdata/workloads/functional-query/queries/QueryTest/create-table-like-table.test@255 PS3, Line 255: drop table if exists allcomplextypes_clone > We shouldn't need this - test_create_table_like_table() uses a unique_datab Done -- To view, visit http://gerrit.cloudera.org:8080/14811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77cd84cda2ed86516937a67eb320fd41e3f1cf2d Gerrit-Change-Number: 14811 Gerrit-PatchSet: 3 Gerrit-Owner: Norbert Luksa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 29 Nov 2019 15:12:06 +0000 Gerrit-HasComments: Yes
