Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14755 )
Change subject: IMPALA-9124: ImpalaServer and ClientRequestState refactoring ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@76 PS5, Line 76: exec_request > nit: update comment Done http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@192 PS5, Line 192: Load > I think "Load" is slightly misleading here, it suggests that this comes fro Done http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@231 PS5, Line 231: const TExecRequest& exec_request() const { > This could DCHECK that the exec_request_ has been initialized. Then you cou I'm actually about to change this again in an upcoming patch, so I'm not sure it is worth it. Would rather do this in a follow up patch. http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/client-request-state.h@471 PS5, Line 471: /// is loaded in LoadExecRequest(TQueryCtx). > Mention that it must not be used before initializing it? Done http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/14755/5/be/src/service/impala-server.h@1091 PS5, Line 1091: shared_ptr > This is now confusing. Done -- To view, visit http://gerrit.cloudera.org:8080/14755 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib92c932a69802225af3fd9bf15f85c85317acaca Gerrit-Change-Number: 14755 Gerrit-PatchSet: 5 Gerrit-Owner: Sahil Takiar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2019 03:42:53 +0000 Gerrit-HasComments: Yes
