Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/14714 )
Change subject: IMPALA-8705: ISO:SQL:2016 datetime patterns - Milestone 3 ...................................................................... Patch Set 9: (6 comments) Some nit comments: http://gerrit.cloudera.org:8080/#/c/14714/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14714/7//COMMIT_MSG@22 PS7, Line 22: - Short day name (DY, Dy, dy): Similar to full day name token but : this works for 3-character day names like 'TUE'. Add "Not suppported in a string to datetime conversion." http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-iso-sql-format-parser.h File be/src/runtime/datetime-iso-sql-format-parser.h: http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-iso-sql-format-parser.h@45 PS7, Line 45: functions function http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-iso-sql-format-parser.h@47 PS7, Line 47: Return nit: Returns http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-iso-sql-format-tokenizer.cc File be/src/runtime/datetime-iso-sql-format-tokenizer.cc: http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-iso-sql-format-tokenizer.cc@207 PS7, Line 207: IsUsedToken("MM") || IsUsedToken("MONTH") || : IsUsedToken("MON") provided_month_tokens == 1 http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-parser-common.h File be/src/runtime/datetime-parser-common.h: http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-parser-common.h@279 PS7, Line 279: number nit: ordinal number http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-parser-common.cc File be/src/runtime/datetime-parser-common.cc: http://gerrit.cloudera.org:8080/#/c/14714/7/be/src/runtime/datetime-parser-common.cc@81 PS7, Line 81: token nit: tokens -- To view, visit http://gerrit.cloudera.org:8080/14714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic797f19a1311b54e5d00d01d0a7afe1f0f21fb8f Gerrit-Change-Number: 14714 Gerrit-PatchSet: 9 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 04 Dec 2019 14:26:48 +0000 Gerrit-HasComments: Yes
