Zoltan Borok-Nagy has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14830


Change subject: IMPALA-9215: report_benchmark_results.py fails with missing key
......................................................................

IMPALA-9215: report_benchmark_results.py fails with missing key

report_benchmark_results.py failed with missing key because it tried
to lookup 'num_instances' from the perf result json file. The JSON
file contained exec summary generated by
impala_beeswax.py::__build_summary_table() which omitted number of
instances.

This patch adds 'num_instances' to the summary table created by
impala_beeswax.py.

To keep report_benchmark_results.py simple it assumes that both perf
json files contain 'num_instances', i.e. if a user issues
single_node_perf_run.py to compare two commits, both of them must
contain this fix.

I tested the PS manually.

Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
---
M tests/beeswax/impala_beeswax.py
M tests/benchmark/report_benchmark_results.py
2 files changed, 6 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/14830/1
--
To view, visit http://gerrit.cloudera.org:8080/14830
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I822c86f621f5a348b56d672c263a2cf9321767ee
Gerrit-Change-Number: 14830
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>

Reply via email to