Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14832 )
Change subject: IMPALA-8184: Add timestamp validation to Orc scanner ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Found some nits, otherwise lgtm. http://gerrit.cloudera.org:8080/#/c/14832/2/common/thrift/generate_error_codes.py File common/thrift/generate_error_codes.py: http://gerrit.cloudera.org:8080/#/c/14832/2/common/thrift/generate_error_codes.py@443 PS2, Line 443: Orc nit: ORC http://gerrit.cloudera.org:8080/#/c/14832/2/testdata/data/README File testdata/data/README: http://gerrit.cloudera.org:8080/#/c/14832/2/testdata/data/README@456 PS2, Line 456: Orc nit: ORC http://gerrit.cloudera.org:8080/#/c/14832/2/testdata/workloads/functional-query/queries/DataErrorsTest/orc-out-of-range-timestamp.test File testdata/workloads/functional-query/queries/DataErrorsTest/orc-out-of-range-timestamp.test: http://gerrit.cloudera.org:8080/#/c/14832/2/testdata/workloads/functional-query/queries/DataErrorsTest/orc-out-of-range-timestamp.test@6 PS2, Line 6: Orc nit: ORC http://gerrit.cloudera.org:8080/#/c/14832/2/testdata/workloads/functional-query/queries/DataErrorsTest/orc-out-of-range-timestamp.test@16 PS2, Line 16: Orc nit: same here -- To view, visit http://gerrit.cloudera.org:8080/14832 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ee2ba83a54f93d37e8832e064f2c8418b503490 Gerrit-Change-Number: 14832 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Norbert Luksa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 10:54:48 +0000 Gerrit-HasComments: Yes
