Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/14857 )
Change subject: [DOCS] Update impala_proxy.xml with the latest info ...................................................................... Patch Set 1: (5 comments) Looks sane overall. I added a few comments. http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml File docs/topics/impala_jdbc.xml: http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@99 PS1, Line 99: Hive 0.13 JDBC driver Does it need to be this specific version? http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@120 PS1, Line 120: Java JAR f I think "JAR/jar files" is concise enough. http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_jdbc.xml@126 PS1, Line 126: The latest JDBC driver, corresponding to Hive 0.13, Is this still true? http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml File docs/topics/impala_proxy.xml: http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml@108 PS1, Line 108: Pick a host other than where <cmdname>impalad</cmdname> is : running. I don't think this is necessarily a requirement. http://gerrit.cloudera.org:8080/#/c/14857/1/docs/topics/impala_proxy.xml@281 PS1, Line 281: start-up option "start-up option" can be understandably mistaken for Impala Daemon process startup options. How about just "impala-shell client flag/option"? -- To view, visit http://gerrit.cloudera.org:8080/14857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9d80e21abb385704eea863d221e333441af9a39 Gerrit-Change-Number: 14857 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2019 19:44:02 +0000 Gerrit-HasComments: Yes
