Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14861 )
Change subject: IMPALA-9219: [DOCS] ISO-SQL 2016 Date/time format patters - Milestone 3 ...................................................................... Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@9 PS1, Line 9: and > nit: are? Done http://gerrit.cloudera.org:8080/#/c/14861/1//COMMIT_MSG@12 PS1, Line 12: IMPALKA > nit: IMPALA Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml File docs/topics/impala_conversion_functions.xml: http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@407 PS1, Line 407: MONTH > Can you also mention that the case is also important when this token is giv Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@410 PS1, Line 410: Month name > "Full month name" would be more self-explanatory Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413 PS1, Line 413: returns > nit: converts to Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@413 PS1, Line 413: string to date/time conversions > For string to datetime conversions could you please add that the expected i 9-character-long, right? http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@415 PS1, Line 415: <p> : In date/time to string conversions, returns a 9-character-long full : month name with trailing spaces. : </p> > I'd also mention that providing FM modifier for this token would result in Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@423 PS1, Line 423: <codeph>MON</codeph> > Similarly to the month token can you mention the differences between MON, M Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@432 PS1, Line 432: <codeph>WW</codeph> > Coudl you mention that 1st week begins on January 1st and ends on the 7th, Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@445 PS1, Line 445: <codeph>W</codeph> > Again, please add: 1st week starts on the 1st of the month and ends on the Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@458 PS1, Line 458: <codeph>D</codeph> > Please add: 1 means Sunday, 2 means Monday, and so on. Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@500 PS1, Line 500: <codeph>DAY</codeph> > Please mention the following things similarly to the full month name token: Done http://gerrit.cloudera.org:8080/#/c/14861/1/docs/topics/impala_conversion_functions.xml@520 PS1, Line 520: <codeph>DY</codeph> > Please mention DY, Dy, and dy for different cases. Done -- To view, visit http://gerrit.cloudera.org:8080/14861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0586445c13cc6d02548be4cca43014066e0d99b Gerrit-Change-Number: 14861 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Alex Rodoni <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2019 20:37:47 +0000 Gerrit-HasComments: Yes
