Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 )
Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server ...................................................................... Patch Set 4: (2 comments) Thanks for making this change. Just one bit of directly looking for SELECT level privilege instead of ANY privilege without checking the value of the config flag. Rest looks good to me. http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java@952 PS4, Line 952: whole server is accessible to given user I would suggest change this to user has SELECT privileges on server (since the javadoc currently suggests that the method checks for full server level access). Same for the userHasDbLevelAccess too. http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java@974 PS4, Line 974: Privilege I think we should check for BackendConfig.INSTANCE.simplifyCheckOnShowTables() here otherwise, we are changing the behavior slightly, right? -- To view, visit http://gerrit.cloudera.org:8080/14867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f5c5d1cf447a9f1cec46c45272f250b8580826 Gerrit-Change-Number: 14867 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 01:17:39 +0000 Gerrit-HasComments: Yes
