Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 )
Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java@952 PS4, Line 952: whole server is accessible to given user > I would suggest change this to user has SELECT privileges on server (since I changed the function to take the privilege as an argument instead. http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java@974 PS4, Line 974: lder( > I think we should check for BackendConfig.INSTANCE.simplifyCheckOnShowTable Changed to ask for different privileges based on simplifyCheckOnShowTables. Using SELECT here instead of ANY didn't change the behavior, it just caused the optimization to applied in less cases. E.g. if the user has no SELECT priv but has CREATE priv, then this function will fail, but all subsequent table level hasAccess() calls will succeed (if ANY privilege is checked), as all tables inherit it from their database. -- To view, visit http://gerrit.cloudera.org:8080/14867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f5c5d1cf447a9f1cec46c45272f250b8580826 Gerrit-Change-Number: 14867 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 13:25:26 +0000 Gerrit-HasComments: Yes
