Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG@15 PS1, Line 15: two test > which two tests? Done http://gerrit.cloudera.org:8080/#/c/14870/1//COMMIT_MSG@15 PS1, Line 15: , > nit: missing space Done http://gerrit.cloudera.org:8080/#/c/14870/1/tests/custom_cluster/test_rpc_exception.py File tests/custom_cluster/test_rpc_exception.py: http://gerrit.cloudera.org:8080/#/c/14870/1/tests/custom_cluster/test_rpc_exception.py@78 PS1, Line 78: assert exception_string in str(e), "Query failed with unexpected exception." > I think it would make this method a bit easier to read if this assert and t Done -- To view, visit http://gerrit.cloudera.org:8080/14870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc Gerrit-Change-Number: 14870 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 16:54:46 +0000 Gerrit-HasComments: Yes
