Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 )
Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server ...................................................................... Patch Set 5: (2 comments) Thanks for making the suggested changes. Patch looks good to me. Left a nit below. http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14867/4/fe/src/main/java/org/apache/impala/service/Frontend.java@974 PS4, Line 974: lder( > Changed to ask for different privileges based on simplifyCheckOnShowTables. right. It is unlikely that user who has create or insert privilege into a table/database does not have select privilege. But since it is a change of behavior I think its good to have it under a flag. http://gerrit.cloudera.org:8080/#/c/14867/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14867/5/fe/src/main/java/org/apache/impala/service/Frontend.java@776 PS5, Line 776: Privilege requiredPrivilege = Privilege.ANY; : if (BackendConfig.INSTANCE.simplifyCheckOnShowTables()) { : requiredPrivilege = Privilege.SELECT; : } nit, may be move this back into the if block since this is unnecessary otherwise. -- To view, visit http://gerrit.cloudera.org:8080/14867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f5c5d1cf447a9f1cec46c45272f250b8580826 Gerrit-Change-Number: 14867 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 18:48:16 +0000 Gerrit-HasComments: Yes
