Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14870 )
Change subject: IMPALA-9209: Fix flakiness in test_end_data_stream_error ...................................................................... IMPALA-9209: Fix flakiness in test_end_data_stream_error TestRPCException.execute_test_query is a helper function that is used by tests that set an RPC debug action to repeatedly run a query until the debug action is hit. Previously, it required that either the query is expected to always succeed, or it must always fail if the debug action is hit and an expected error is provided. However, the two tests that have an expected error, test_end_data_stream_error and test_transmit_data_error, both set two debug actions - one that will cause a query failure and one that won't (because we always retry 'reject too busy' errors). If only the debug action that doesn't cause query failure is hit, the query won't fail and 'execute_test_query' will fail on the assert that expects that the query must fail if the action was hit. This is rare, as both debug actions have a high probability of being hit on a given run of the query. The solution is to remove the requirement from the tests that the query must fail if an expected error is provided and the debug action is hit. Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc Reviewed-on: http://gerrit.cloudera.org:8080/14870 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/custom_cluster/test_rpc_exception.py 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/14870 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I499955b2d61c6b806f78e124c7ab919b242921bc Gerrit-Change-Number: 14870 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]>
