Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14884 )
Change subject: IMPALA-9235: add more per-connection stats to /rpcz ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/14884/5/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/14884/5/be/src/rpc/rpc-mgr.cc@315 PS5, Line 315: document->AddMember("per_conn_metrics", outbound_per_conn_metrics, document->GetAllocator()); > line too long (95 > 90) Done http://gerrit.cloudera.org:8080/#/c/14884/5/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/14884/5/tests/webserver/test_web_pages.py@569 PS5, Line 569: print conn > remove? Oops http://gerrit.cloudera.org:8080/#/c/14884/5/tests/webserver/test_web_pages.py@571 PS5, Line 571: assert conn["num_calls_in_flight"] >= 0 : assert len(conn["calls_in_flight"]) >= 0 > Could also check that these are equal Done -- To view, visit http://gerrit.cloudera.org:8080/14884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3696463e22123fe81073af4aa495a96b7d4f7ee2 Gerrit-Change-Number: 14884 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 23:26:08 +0000 Gerrit-HasComments: Yes
