Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14764 )
Change subject: IMPALA-4192: Move static state from ExecNode into a PlanNode ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/cardinality-check-node.cc File be/src/exec/cardinality-check-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/cardinality-check-node.cc@29 PS10, Line 29: Status CardinalityCheckPlanNode::CreateExecNode(RuntimeState* state, ExecNode** node) const { line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/nested-loop-join-node.cc File be/src/exec/nested-loop-join-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/nested-loop-join-node.cc@54 PS10, Line 54: Status NestedLoopJoinPlanNode::CreateExecNode(RuntimeState* state, ExecNode** node) const { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/singular-row-src-node.cc File be/src/exec/singular-row-src-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/singular-row-src-node.cc@25 PS10, Line 25: Status SingularRowSrcPlanNode::CreateExecNode(RuntimeState* state, ExecNode** node) const { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/topn-node.cc File be/src/exec/topn-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/topn-node.cc@64 PS10, Line 64: TopNNode::TopNNode(ObjectPool* pool, const TopNPlanNode& pnode, const DescriptorTbl& descs) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/union-node.cc File be/src/exec/union-node.cc: http://gerrit.cloudera.org:8080/#/c/14764/10/be/src/exec/union-node.cc@69 PS10, Line 69: UnionNode::UnionNode(ObjectPool* pool, const UnionPlanNode& pnode, const DescriptorTbl& descs) line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14764 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69f1676bf67bac31fa5902511b3fcc269fd67472 Gerrit-Change-Number: 14764 Gerrit-PatchSet: 10 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2019 02:34:04 +0000 Gerrit-HasComments: Yes
