Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14894 )
Change subject: IMPALA-9009: Core support for Ranger column masking ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/14894/2/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java File fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java: http://gerrit.cloudera.org:8080/#/c/14894/2/fe/src/main/java/org/apache/impala/analysis/InlineViewRef.java@165 PS2, Line 165: LOG.trace("Replace '{}' with subquery: {}", tableRef.toSql(), tableMaskStmt.toSql()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/14894/2/fe/src/main/java/org/apache/impala/authorization/TableMask.java File fe/src/main/java/org/apache/impala/authorization/TableMask.java: http://gerrit.cloudera.org:8080/#/c/14894/2/fe/src/main/java/org/apache/impala/authorization/TableMask.java@50 PS2, Line 50: public Expr getColumnMask(String colName, Type colType) throws InternalException, AnalysisException { line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/14894/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/14894/2/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@284 PS2, Line 284: String transformer = null; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/14894/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/14894/2/tests/authorization/test_ranger.py@606 PS2, Line 606: . flake8: E131 continuation line unaligned for hanging indent -- To view, visit http://gerrit.cloudera.org:8080/14894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4cad60e0e69ea573b7ecfc011b142c46ef52ed61 Gerrit-Change-Number: 14894 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2019 12:05:30 +0000 Gerrit-HasComments: Yes
