Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/14319 )
Change subject: IMPALA-8984: Fix race condition in creating Kudu table ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/14319/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14319/13/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2223 PS13, Line 2223: createManagedTable It looks like this method is not thread-safe either. It is possible that two threads executing this method for the same table, may both see the table is not existing and both trying to create the table. Perhaps, the better way to fix this race is to increase the scope of DdlLock_ to include both the kudu table creation and hms table creation. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/14319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a4047bcdaa6b346765b96e8c36bb747a2b0091d Gerrit-Change-Number: 14319 Gerrit-PatchSet: 13 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2019 18:50:25 +0000 Gerrit-HasComments: Yes
