Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14898 )
Change subject: IMPALA-9244 Bump up boost to work on aarch64 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14898/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/14898/2/buildall.sh@46 PS2, Line 46: if [[ "$ARCH_NAME" == "aarch64" ]]; then Can you add this boost version for all architectures? So we can test on x86 if we want to bump the version. I think this is cleaner if you just skip the boost versions that don't work with ARM I.e. if [[ "$ARCH_NAME" != "aarch64" ]]; then if (( BUILD_HISTORICAL )) ; then BOOST_VERSION=1.57.0 $SOURCE_DIR/source/boost/build.sh BOOST_VERSION=1.57.0-p1 $SOURCE_DIR/source/boost/build.sh BOOST_VERSION=1.57.0-p2 $SOURCE_DIR/source/boost/build.sh fi BOOST_VERSION=1.57.0-p3 $SOURCE_DIR/source/boost/build.sh fi BOOST_VERSION=1.61.0 $SOURCE_DIR/source/boost/build.sh http://gerrit.cloudera.org:8080/#/c/14898/2/source/boost/build.sh File source/boost/build.sh: http://gerrit.cloudera.org:8080/#/c/14898/2/source/boost/build.sh@28 PS2, Line 28: if [[ "$ARCH_NAME" == "aarch64" ]]; then This is a hack. We don't want to add a URL to a different S3 bucket. I can upload the boost source to the regular toolchain S3 bucket -- To view, visit http://gerrit.cloudera.org:8080/14898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia54aeb93f1a99a0f976fc63f2127c4f06b5ffb24 Gerrit-Change-Number: 14898 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2019 16:59:51 +0000 Gerrit-HasComments: Yes
