Jiawei Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14776 )
Change subject: IMPALA-7550: Add documentation to profile counters ...................................................................... Patch Set 9: (4 comments) Hi Tim, thanks for the review! http://gerrit.cloudera.org:8080/#/c/14776/8/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/14776/8/be/src/util/default-path-handlers.cc@54 PS8, Line 54: constexpr ProfileEntryPrototype::Significance ProfileEntryPrototype::ALLSIGNIFICANCE[]; > Include util/runtime-profile-counters.h instead of redeclaring it. I have tried this way but it won't compile... The error is error: undefined reference to 'impala::ProfileEntryPrototype::ALLSIGNIFICANCE' I am not sure if I did it wrong? http://gerrit.cloudera.org:8080/#/c/14776/8/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/14776/8/be/src/util/runtime-profile.cc@109 PS8, Line 109: fo > nit: for Done http://gerrit.cloudera.org:8080/#/c/14776/8/be/src/util/runtime-profile.cc@115 PS8, Line 115: "; > Maybe remove this sentence? Done http://gerrit.cloudera.org:8080/#/c/14776/8/be/src/util/runtime-profile.cc@115 PS8, Line 115: circumstance > nit: circumstances Done -- To view, visit http://gerrit.cloudera.org:8080/14776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc03faddb27754001290bb6d899840e2cbe7ccb7 Gerrit-Change-Number: 14776 Gerrit-PatchSet: 9 Gerrit-Owner: Jiawei Wang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Balazs Jeszenszky <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Reviewer: Jiawei Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 13 Dec 2019 20:04:27 +0000 Gerrit-HasComments: Yes
