Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14867 )
Change subject: IMPALA-9222: Speed up show tables/DBs if the user has access to parent db/server ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14867/5/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14867/5/fe/src/main/java/org/apache/impala/service/Frontend.java@776 PS5, Line 776: if (authzFactory_.getAuthorizationConfig().isEnabled() : && !userHasDbLevelAccess(user, dbName)) { : Privilege requiredPrivilege = Privilege.ANY; : > nit, may be move this back into the if block since this is unnecessary othe I kept them outside, as moving them inside + using them in an if would increase the nesting of the while loop further. -- To view, visit http://gerrit.cloudera.org:8080/14867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1f5c5d1cf447a9f1cec46c45272f250b8580826 Gerrit-Change-Number: 14867 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Mon, 16 Dec 2019 16:10:04 +0000 Gerrit-HasComments: Yes
