Zhou Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14846 )
Change subject: IMPALA-9195: Using multithreaded execution to accelerate 'show tables/databases' ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/14846/7/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/14846/7/fe/src/main/java/org/apache/impala/service/Frontend.java@859 PS7, Line 859: submit > I am not familiar with ExecutorService, so I may be wrong here. You are right. All the check tasks created concurrently by the users when executing 'show databases/tables' will be submitted to the static thread pool. All the fe_service_threads used by users when executing 'show databases/tables' will be blocked until check tasks being finished. For the current state, 'show databases/ tables' will be executed in separate client request thread. The method of newFixedThreadPool sets corePoolSize and maximumPoolSize to the same value. Now the problem changes to how to set the corePoolSize and maximumPoolSize for ThreadPoolExecutor. Any suggestion ? -- To view, visit http://gerrit.cloudera.org:8080/14846 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I860e0d18afa0421665f8b3b1c5561d6bdacc5e96 Gerrit-Change-Number: 14846 Gerrit-PatchSet: 7 Gerrit-Owner: Zhou Xu <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zhou Xu <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2019 12:52:50 +0000 Gerrit-HasComments: Yes
