Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14799 )
Change subject: IMPALA-9101: Add support for detecting self-events on partition events ...................................................................... Patch Set 2: (3 comments) Thanks for making this change. Overall, the patch looks good to me. I just posted some questions to understand a few things better. http://gerrit.cloudera.org:8080/#/c/14799/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/14799/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1383 PS2, Line 1383: reloadPartition(tPartSpec, "ADD_PARTITION"); Just for my understanding, here and in DropPartitionEvents, are we changing the behavior from bailing out of refreshing the rest of the partitions when we encounter a failed refresh to a best-effort (refresh as many partitions in the event as possible) refresh? http://gerrit.cloudera.org:8080/#/c/14799/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/14799/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@210 PS2, Line 210: NUMBER_OF_PARTITION_REFRESHES Should this metric be initialized similarly to table refreshes in line 316? http://gerrit.cloudera.org:8080/#/c/14799/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/14799/2/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@631 PS2, Line 631: catalog_.addVersionsForInflightEvents(tbl, newCatalogVersion); Is there a reason why we are not doing this for DROP_PARTITION case below on L650? -- To view, visit http://gerrit.cloudera.org:8080/14799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b4148f6be0f9f946c8ad8f314d64b095731744c Gerrit-Change-Number: 14799 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Anurag Mantripragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 17 Dec 2019 18:44:11 +0000 Gerrit-HasComments: Yes
