Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14917 )
Change subject: IMPALA-9197: make HashTable lookups thread-safe ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/14917/3/be/src/exec/hash-table.h File be/src/exec/hash-table.h: http://gerrit.cloudera.org:8080/#/c/14917/3/be/src/exec/hash-table.h@953 PS3, Line 953: HtData* IR_ALWAYS_INLINE InsertInternal(HashTableCtx* __restrict__ ht_ctx, Status* status); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/14917/3/be/src/exec/hash-table.h@962 PS3, Line 962: Status ResizeBuckets(int64_t num_buckets, HashTableCtx* __restrict__ ht_ctx, bool* got_memory); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/14917/3/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: http://gerrit.cloudera.org:8080/#/c/14917/3/be/src/exec/hash-table.cc@517 PS3, Line 517: Probe<true, false>(new_buckets, num_buckets, ht_ctx, bucket_to_copy->hash, &found); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/14917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92fbfa8cc000477b8e01975a102d818f9fa27c61 Gerrit-Change-Number: 14917 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 18 Dec 2019 05:20:59 +0000 Gerrit-HasComments: Yes
