Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14798 )
Change subject: IMPALA-9149: part 1: Re-enabe Ranger-related FE tests ...................................................................... Patch Set 14: (7 comments) Just have some nits. Otherwise can give a +2. Thanks for the fixes! http://gerrit.cloudera.org:8080/#/c/14798/14/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/14798/14/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2826 PS14, Line 2826: USER nit: user_ http://gerrit.cloudera.org:8080/#/c/14798/14/fe/src/test/java/org/apache/impala/authorization/AuthorizationStmtTest.java@2831 PS14, Line 2831: AuthorizationTestBase. nit: I think we don't need the base class name here. We can use user_ directly. http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/bin/create-load-data.sh@377 PS14, Line 377: ${RANGER_SETUP_DIR}/policy_4_revised.json It'd be better to double quote the file path in case there're any whitespaces in ${RANGER_SETUP_DIR} http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/cluster/ranger/setup/policy_4_revised.json File testdata/cluster/ranger/setup/policy_4_revised.json: http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/cluster/ranger/setup/policy_4_revised.json@3 PS14, Line 3: "createTime": 1576626853006, I think we can remove this. http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/cluster/ranger/setup/policy_4_revised.json@9 PS14, Line 9: "guid": "a2206d12-fd92-437c-903a-c4eb3fb12381", Also remove this to avoid flaky failures. http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/cluster/ranger/setup/policy_4_revised.json@103 PS14, Line 103: "resourceSignature": "319fd63cad4bb7c8ed17fda910b636dc2e0f6b0112e28487d9e44e8a5c846314", Also remove this to avoid flaky failures. http://gerrit.cloudera.org:8080/#/c/14798/14/testdata/cluster/ranger/setup/policy_4_revised.json@116 PS14, Line 116: "updateTime": 1576626853008, I think we can remove this too. -- To view, visit http://gerrit.cloudera.org:8080/14798 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I228533aae34b9ac03bdbbcd51a380770ff17c7f2 Gerrit-Change-Number: 14798 Gerrit-PatchSet: 14 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 20 Dec 2019 02:34:36 +0000 Gerrit-HasComments: Yes
