Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14811 )
Change subject: IMPALA-8046: Support CREATE TABLE from an ORC file ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/14811/8/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/14811/8/fe/pom.xml@309 PS8, Line 309: <groupId>org.apache.orc</groupId> > I think we need to add ORC stuffs in shaded-deps/pom.xml so we don't use or Done http://gerrit.cloudera.org:8080/#/c/14811/8/fe/src/main/java/org/apache/impala/analysis/OrcSchemaExtractor.java File fe/src/main/java/org/apache/impala/analysis/OrcSchemaExtractor.java: http://gerrit.cloudera.org:8080/#/c/14811/8/fe/src/main/java/org/apache/impala/analysis/OrcSchemaExtractor.java@181 PS8, Line 181: * parsing the ORC schema, or if the ORC types cannot be represented in Impala. > Change Parquet to ORC Done http://gerrit.cloudera.org:8080/#/c/14811/8/fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java File fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java: http://gerrit.cloudera.org:8080/#/c/14811/8/fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java@28 PS8, Line 28: ORCSchemeExtractor and ParquetScheme > nit: OrcSchemaExtractor and ParquetSchemaExtractor Done http://gerrit.cloudera.org:8080/#/c/14811/8/fe/src/main/java/org/apache/impala/util/FileAnalysisUtil.java@35 PS8, Line 35: public static void CheckIfFile(Path pathToFile) throws AnalysisException { > What about merging this into FileSystemUtil.java? Other utilities for files Thought about that, but this file contains Analysis specific utilities and as I saw FileSystemUtil.java has nothing of the sort, so I did not want to mingle them. -- To view, visit http://gerrit.cloudera.org:8080/14811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77cd84cda2ed86516937a67eb320fd41e3f1cf2d Gerrit-Change-Number: 14811 Gerrit-PatchSet: 10 Gerrit-Owner: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Norbert Luksa <norbert.lu...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Dec 2019 09:00:41 +0000 Gerrit-HasComments: Yes
